Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate missing ';' in oneof options/fields and extension fields #216

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Dec 5, 2023

While still reporting an error, see: #200
A little different from the others, as oneof and extensions don't support empty decls.

@Alfus Alfus requested a review from jhump December 5, 2023 19:17
@Alfus Alfus changed the title Tolerate missing ';' in oneof options and fields Tolerate missing ';' in oneof options/fields and extension fields Dec 5, 2023
@Alfus Alfus merged commit 340bf80 into main Dec 7, 2023
8 checks passed
@Alfus Alfus deleted the alfus/oneofsemi branch December 7, 2023 02:58
kralicky pushed a commit to kralicky/protocompile that referenced this pull request Feb 7, 2024
…fbuild#216)

While still reporting an error, see:
bufbuild#200
A little different from the others, as oneof and extensions don't
support empty decls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants