Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break dependency on protobuf.bzl from google/protobuf for C++ #92

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Break dependency on protobuf.bzl from google/protobuf for C++ #92

merged 2 commits into from
Aug 8, 2018

Commits on Aug 7, 2018

  1. Break dependency on protobuf.bzl from google/protobuf for C++ 

    This replaces the use of cc_proto_library / proto_gen from the
@com_google_protobuf//:protobuf.bzl. The reason for doing so is that
newer versions of google/protobuf have changed cc_proto_library +
proto_gen so that they no longer work with pgv_cc_proto_library.

pgv_proto_library now takes a proto_library containing the protos
instead of a list of proto files. The approach for generating the protoc
command line arguments was taken from bazelbuild/rules_go

The py_proto_library imported from @com_google_protobuf//:protobuf.bzl
is used by Envoy, so we left it in.

Signed-off-by: Andrew Keesler <akeesler@pivotal.io>
Signed-off-by: Amin Jamali <ajamali@pivotal.io>
    @sesmith177
    sesmith177 authored and Amin Jamali committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    ef10f42 View commit details
    Browse the repository at this point in the history

  2. Fix nits 

    - change mnemonic to ProtoGenValidateCcGenerate
- accept array of proto_library rules as argument

Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @sesmith177
    Amin Jamali authored and sesmith177 committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    8de9627 View commit details
    Browse the repository at this point in the history