Fix Edition type modification for the edition property of DescFile (#626

)
bufbuild · Nov 21, 2023 · 1f3faa6 · 1f3faa6
1 parent 8a23052
commit 1f3faa6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/protobuf/src/create-descriptor-set.ts b/packages/protobuf/src/create-descriptor-set.ts
@@ -640,7 +640,7 @@ function parseFileSyntax(
   syntax: string | undefined,
   edition: Edition | undefined,
 ) {
-  let e: Omit<
+  let e: Exclude<
     Edition,
     | Edition.EDITION_1_TEST_ONLY
     | Edition.EDITION_2_TEST_ONLY

diff --git a/packages/protobuf/src/descriptor-set.ts b/packages/protobuf/src/descriptor-set.ts
@@ -91,7 +91,7 @@ export interface DescFile {
    * The edition of the protobuf file. Will be EDITION_PROTO2 for syntax="proto2",
    * EDITION_PROTO3 for syntax="proto3";
    */
-  readonly edition: Omit<
+  readonly edition: Exclude<
     Edition,
     | Edition.EDITION_1_TEST_ONLY
     | Edition.EDITION_2_TEST_ONLY