Handle private network preflight requests in Studio agent with flag --private-network
#1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
approved these changes
Feb 27, 2023
bufdev
approved these changes
Feb 27, 2023
twoism
pushed a commit
that referenced
this pull request
Mar 2, 2023
…--private-network` (#1863) This PR adds a `--private-network` boolean flag that allows the Studio agent to handle preflight requests from Studio in private networks that set the `Access-Control-Request-Private-Network` header set. We still want to preserve the default behaviour of rejecting preflight requests if the flag has not been set.
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
…--private-network` (bufbuild#1863) This PR adds a `--private-network` boolean flag that allows the Studio agent to handle preflight requests from Studio in private networks that set the `Access-Control-Request-Private-Network` header set. We still want to preserve the default behaviour of rejecting preflight requests if the flag has not been set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--private-networkboolean flag that allows the Studio agent to handlepreflight requests from Studio in private networks that set the
Access-Control-Request-Private-Networkheader set.
We still want to preserve the default behaviour of rejecting preflight requests if the flag has not been set.