Preserve unknown fields when converting between FileDescriptorProto and ImageFile
#1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
Feb 22, 2023
| @@ -455,22 +455,19 @@ func TestBasic(t *testing.T) { | |||
| ) | |||
| diff := cmp.Diff(protoImage, bufimage.ImageToProtoImage(newImage), protocmp.Transform()) | |||
| require.Equal(t, "", diff) | |||
| // TODO: all of the below proto equality checks should use cmp.Diff | |||
There was a problem hiding this comment.
I had to address this TODO because now that the ProtoReflect method might be called (to query/set unknown fields), the internal, unexported atomicMessageState pointer field of the message can differ between the two messages being compared (previously, by coincidence, was always nil on both sides).
bufdev
approved these changes
Feb 23, 2023
jhump
deleted the
jh/preserve-unknown-fields-when-converting-between-filedescriptorproto-and-imagefile
branch
twoism
pushed a commit
that referenced
this pull request
Mar 2, 2023
… and `ImageFile` (#1855) This way, if a field is ever added to the descriptors and then serialized by a newer version of `buf`, an older version of `buf` won't mangle it and inadvertently drop those newer fields.
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
… and `ImageFile` (bufbuild#1855) This way, if a field is ever added to the descriptors and then serialized by a newer version of `buf`, an older version of `buf` won't mangle it and inadvertently drop those newer fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if a field is ever added to the descriptors and then serialized by a newer version of
buf, an older version ofbufwon't mangle it and inadvertently drop those newer fields.The place in
protodescriptoris the code path used for converting an image file to a descriptor proto. And the place inbufimageis for the other direction.