Set --source-control-url on push #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doriable @emcfarlane I have not actually tested this. Please test and takeover this PR to make any changes necessary. |
nicksnyder
commented
Jan 29, 2025
| // We want push to succeed without additional user configuration even if the action is being run on an | ||
| // enterprise GitHub instance. Because enterprise GitHub instances can have an arbitrary URL, the Buf CLI with not be | ||
| // able to automatically detect the source control url, so we set it explicitly. | ||
| const sourceControlUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/commit/${context.sha}`; |
There was a problem hiding this comment.
Could have tried to make this conditional and only set this if we are on an enterprise instance, but it seems better/simpler to always set it and ensure it works everywhere instead of having multiple code paths.
nicksnyder
changed the title
This comment has been minimized.
This comment has been minimized.
doriable
approved these changes
Jan 29, 2025
Merged
emcfarlane
added a commit
that referenced
this pull request
Jan 29, 2025
Below is the draft release notes: ## What's Changed * Add migration guide doc by @emcfarlane in #74 * Set --debug when the action is using debug logging by @emcfarlane in #78 * Set --source-control-url on push so that the push action now works by default on enterprise GitHub instances by @nicksnyder in #86 ## New Contributors * @doriable made their first contribution in #98 **Full Changelog**: v1.0.2...v1.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures push will work on enterprise GitHub instances that have arbitrary URLs.