Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1101 users role sorting #1103

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Fix/1101 users role sorting #1103

merged 4 commits into from
Jan 13, 2025

Conversation

ExiRain
Copy link
Collaborator

@ExiRain ExiRain commented Dec 31, 2024

  • Added exception for sorting by role

Related task.

@ExiRain ExiRain requested a review from 1AhmedYasser December 31, 2024 10:43
@ExiRain ExiRain mentioned this pull request Dec 31, 2024
Open
1AhmedYasser
1AhmedYasser approved these changes Jan 2, 2025 •
edited
Loading
View reviewed changes
1AhmedYasser
1AhmedYasser suggested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@1AhmedYasser 1AhmedYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve sonar issues

@ExiRain
Copy link
Collaborator Author

ExiRain commented Jan 2, 2025

Done

@rasmusei rasmusei linked an issue Jan 4, 2025 that may be closed by this pull request
[BUG] Administration User module table alphabetical order does not work with role sorting #1101
Open
@rasmusei
Copy link
Contributor

rasmusei commented Jan 4, 2025

@ExiRain please resolve conflicts

1AhmedYasser
1AhmedYasser approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@1AhmedYasser 1AhmedYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rasmusei rasmusei merged commit 7f47293 into buerokratt:v2.0.2 Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1AhmedYasser 1AhmedYasser 1AhmedYasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Administration User module table alphabetical order does not work with role sorting
3 participants
@ExiRain @rasmusei @1AhmedYasser