refactor: changed transaction handling related to Account package #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakcy
force-pushed
the
update-storage-client-account
branch
from
eac85c2 to
475aec4
Compare
kakcy
commented
Feb 13, 2025
pkg/account/api/account.go
Outdated
Comment on lines
232
to
234
| return s.auditlogStorage.CreateAuditLog( | ||
| contextWithTx, | ||
| domainauditlog.NewAuditLog(createAccountEvent, storage.AdminEnvironmentID), | ||
| ) |
There was a problem hiding this comment.
@cre8ivejp
I tried implementing support for updating AuditLog within the same transaction.
Supporting NoCommand like this will generate an Event, so it would be a good idea to update AuditLog based on that.
Please check when you are free.
| @@ -78,6 +78,56 @@ func (h *autoOpsRuleCommandHandler) Handle(ctx context.Context, cmd Command) err | |||
| return errUnknownCommand | |||
| } | |||
|
|
|||
| // func (h *autoOpsRuleCommandHandler) NewEvent(ctx context.Context, cmd Command) (*eventproto.Event, error) { | |||
There was a problem hiding this comment.
I think we can delete this directly.
kakcy
commented
Feb 26, 2025
Comment on lines
-202
to
+203
| createAccountEvent, err = domainevent.NewEvent( | ||
| createAccountEvent, err = domainevent.NewAdminEvent( |
There was a problem hiding this comment.
@cre8ivejp
Check the code below I think the Account-related AuditLog needs to be saved in AdminAuditLog, so I made some changes.
https://github.com/bucketeer-io/bucketeer/blob/main/pkg/account/command/account_v2.go#L372
|
@kakcy, please fix the conflict. |
kakcy
force-pushed
the
update-storage-client-account
branch
from
a5573ff to
453174a
Compare
|
@cre8ivejp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
pkg/account/api/account.gofile, focusing on updating transaction handling and integrating audit log creation. Additionally, it includes corresponding updates to the test filepkg/account/api/account_test.go.Part of #1474
Part of #1002