Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add schedule update field to feature proto message #1506

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: add schedule update field to feature proto message #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions api-description/apidocs.swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2420,6 +2420,11 @@ definitions:
$ref: '#/definitions/featurePrerequisite'
samplingSeed:
type: string
scheduleUpdate:
type: array
items:
type: object
$ref: '#/definitions/featureScheduleUpdate'
featureFeatureLastUsedInfo:
type: object
properties:
Expand Down Expand Up @@ -2511,6 +2516,14 @@ definitions:
items:
type: object
$ref: '#/definitions/featureClause'
featureScheduleUpdate:
type: object
properties:
feature:
$ref: '#/definitions/featureFeature'
updateAt:
type: string
format: int64
featureSegmentUser:
type: object
properties:
Expand Down
13 changes: 13 additions & 0 deletions api-description/web-api.swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7509,6 +7509,11 @@ definitions:
$ref: '#/definitions/featurePrerequisite'
samplingSeed:
type: string
scheduleUpdate:
type: array
items:
type: object
$ref: '#/definitions/featureScheduleUpdate'
featureFeatureLastUsedInfo:
type: object
properties:
Expand Down Expand Up @@ -7776,6 +7781,14 @@ definitions:
items:
type: object
$ref: '#/definitions/bucketeerfeatureClause'
featureScheduleUpdate:
type: object
properties:
feature:
$ref: '#/definitions/featureFeature'
updateAt:
type: string
format: int64
featureSegment:
type: object
properties:
Expand Down
2 changes: 1 addition & 1 deletion manifests/bucketeer/charts/api/values.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions manifests/bucketeer/charts/web/values.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified proto/auditlog/proto_descriptor.pb
View file
Open in desktop
Binary file not shown.
189 changes: 139 additions & 50 deletions proto/feature/feature.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions proto/feature/feature.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ message Feature {
bool archived = 20;
repeated Prerequisite prerequisites = 21;
string sampling_seed = 22;
repeated ScheduleUpdate schedule_update = 23;
}

message Features {
Expand All @@ -71,3 +72,8 @@ message Tag {
int64 updated_at = 3;
string name = 4;
}

message ScheduleUpdate {
Feature feature = 1;
int64 update_at = 2;
}
Binary file modified proto/feature/proto_descriptor.pb
View file
Open in desktop
Binary file not shown.
Binary file modified proto/gateway/proto_descriptor.pb
View file
Open in desktop
Binary file not shown.
21 changes: 21 additions & 0 deletions proto/proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25662,6 +25662,12 @@
"id": 22,
"name": "sampling_seed",
"type": "string"
},
{
"id": 23,
"name": "schedule_update",
"type": "ScheduleUpdate",
"is_repeated": true
}
]
},
Expand Down Expand Up @@ -25721,6 +25727,21 @@
"type": "string"
}
]
},
{
"name": "ScheduleUpdate",
"fields": [
{
"id": 1,
"name": "feature",
"type": "Feature"
},
{
"id": 2,
"name": "update_at",
"type": "int64"
}
]
}
],
"imports": [
Expand Down
Loading
Loading