Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement REST get segment, list segments, create segment #1418

Merged
merged 4 commits into from
Jan 8, 2025
Merged

feat: implement REST get segment, list segments, create segment #1418

merged 4 commits into from
Jan 8, 2025

Conversation

hvn2k1
Copy link
Contributor

@hvn2k1 hvn2k1 commented Jan 7, 2025 •
edited
Loading

Part of #1417

  • Deprecate command from create segment and bulk upload user segment API
  • Implement REST for get, list and create segment

@hvn2k1 hvn2k1 marked this pull request as ready for review January 7, 2025 10:02
@cre8ivejp
Copy link
Member

@hvn2k1, the PR looks good! Thanks.
Please fix the conflicts so I can approve it.

@hvn2k1 hvn2k1 force-pushed the feat/list-user-segment branch from bd50bf1 to 905edf8 Compare January 8, 2025 02:11
@hvn2k1
Copy link
Contributor Author

hvn2k1 commented Jan 8, 2025

@cre8ivejp I have resolved conflicts

cre8ivejp
cre8ivejp approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@hvn2k1 hvn2k1 merged commit 8608fe3 into main Jan 8, 2025
21 checks passed
@hvn2k1 hvn2k1 deleted the feat/list-user-segment branch January 8, 2025 04:33
@bucketeer-bot bucketeer-bot mentioned this pull request Jan 8, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

@kentakozuka kentakozuka Awaiting requested review from kentakozuka kentakozuka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvn2k1 @cre8ivejp