chore: add environment_id label to evaluation event metrics (#1391)

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
bucketeer-io · Dec 19, 2024 · ffe8c83 · ffe8c83
1 parent 1764266
commit ffe8c83
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pkg/subscriber/processor/evaluation_events_evaluation_count_event_persister.go b/pkg/subscriber/processor/evaluation_events_evaluation_count_event_persister.go
@@ -269,7 +269,13 @@ func (p *evaluationCountEventPersister) incrementEvaluationCount(
 			)
 			return err
 		}
-		evaluationEventCounter.WithLabelValues(e.SdkVersion, e.FeatureId, e.Metadata[appVersion], e.VariationId).Inc()
+		evaluationEventCounter.WithLabelValues(
+			environmentId,
+			e.SdkVersion,
+			e.FeatureId,
+			e.Metadata[appVersion],
+			e.VariationId,
+		).Inc()
 	}
 	return nil
 }

diff --git a/pkg/subscriber/processor/metrics.go b/pkg/subscriber/processor/metrics.go
@@ -87,7 +87,7 @@ var (
 			Subsystem: "subscriber",
 			Name:      "evaluation_event_total",
 			Help:      "Total number of evaluation events",
-		}, []string{"sdk_version", "feature_id", "app_version", "variation_id"})
+		}, []string{"environment_id", "sdk_version", "feature_id", "app_version", "variation_id"})
 )
 
 func registerMetrics(r metrics.Registerer) {