fix: rename the plugin

the plugin has a misleading name in the list of plugins. It is form creator, then it must show with these words

closes pluginsGLPI#1264

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

install/upgrade_to_2.7.php

@@ -306,5 +306,13 @@ public function upgrade(Migration $migration) {
          $id = $row['id'];
          $DB->query("UPDATE `glpi_plugin_formcreator_forms` SET `name` = '$name', `description` = '$description', `content` = '$content' WHERE `id` = '$id'");
       }
+
+      // Rename the plugin
+      $plugin = new Plugin();
+      $plugin->getFromDBbyDir('formcreator');
+      $success = $plugin->update([
+         'id' => $plugin->getID(),
+         'name' => 'Form Creator',
+      ]);
    }
 }

setup.php

@@ -56,7 +56,7 @@ function plugin_version_formcreator() {
       return false;
    }
    $requirements = [
-      'name'           => _n('Form', 'Forms', 2, 'formcreator'),
+      'name'           => 'Form Creator',
       'version'        => PLUGIN_FORMCREATOR_VERSION,
       'author'         => '<a href="http://www.teclib.com">Teclib\'</a>',
       'homepage'       => 'https://github.com/pluginsGLPI/formcreator',