Set the actual local port number to btrace.port
system property
#461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
BTrace agent currently sets the port number given by a user to
btrace.port
system property as-is. This behavior can be a problemwhen:
may still attempt to connect to the port number specified in
btrace.port
, where other server may be running already there.the user specified
0
as the port number, because we only know theactual port number after creating a server socket on it.
Modifications:
ServerSocket
sothat a user can later figure out the actual port number even if the
user specified
0
as the port number.Result:
specified
0
.the existence of
btrace.port
System property.