Verify psbt input data before finalizing #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Mar 20, 2023
wallet/psbt.go
Outdated
| @@ -389,6 +389,13 @@ func (w *Wallet) FinalizePsbt(keyScope *waddrmgr.KeyScope, account uint32, | |||
| return err | |||
| } | |||
|
|
|||
| // Let't check that every input has either the nonwitness field or the | |||
| // witnessUtxo field populated. | |||
| err = psbt.VerifyInputs(packet) | |||
There was a problem hiding this comment.
If we end up calling VerifyInputOutputLen in VerifyInputs (see other PR), we might as well replace the call above with this one.
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
b6b4f40 to
6321f85
Compare
7 tasks
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
6321f85 to
347e048
Compare
| // this call. | ||
| // wallet accounts (NP2WKH, P2WKH, P2TR), so any | ||
| // key scope provided doesn't impact the result | ||
| // of this call. |
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
515be82 to
4215cb9
Compare
|
I pushed a new tag |
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
4215cb9 to
01a2e9d
Compare
guggero
approved these changes
Mar 23, 2023
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
Verify psbt input data before finalizing
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
Verify psbt input data before finalizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to lightningnetwork/lnd#7527 and btcsuite/btcd#1964.
This would be my solution where I would fix the problem in lnd, happy to here your thoughts.
Or should we maybe directly check this in the lnd project/package ?