-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check consistency of account id, name index on open #261
base: master
Are you sure you want to change the base?
Conversation
ba2ced7
to
4798b83
Compare
Shouldn't this be accompanied by a version bump? It doesn't need to happen on every single open. |
4798b83
to
c02bf11
Compare
There was a suggestion on IRC that we always have a consistency check on account indexes on startup. Right now this involves deserializing each account row so it might be inefficient and an overkill. I'll check on IRC and move this to a version bump and upgrade in case that seems more favorable. |
and maybe a flag.. ./btcwallet --check to check consistency. |
e72e51a
to
58f9dc5
Compare
Added a upgrade as well as flag |
ac660bc
to
5fc2e8f
Compare
2406368
to
0040e57
Compare
0040e57
to
2bd3a28
Compare
2bd3a28
to
cd2d903
Compare
cd2d903
to
a0bc0a5
Compare
Remove duplicate NeutrinoClient interface Merge btcsuite#265 cache+neutrino: add new cache module by @Roasbeef Merge btcsuite#261 cache+neutrino: update existing Cache interface to use type parameters by @Roasbeef Merge btcsuite#268 cache: add deletion and iteration methods by @yyforyongyu Merge btcsuite#279 lru: add methods to range with orders by @yyforyongyu Merge btcsuite#278 pushtx: map different backend err to internal err by @ziggie1984 Merge btcsuite#273 query+neutrino: use query dispatcher for GetBlock and GetCFilte by @ellemouton Merge btcsuite#274 multi: introduce a batch filter writer by @ellemouton Merge btcsuite#275 rescan: use batch filter fetching by @ellemouton Merge btcsuite#283 blockmanager.go: use btcd libs to validate headers by @guggero Merge btcsuite#288 neutrino: Added ResetRanking method to PeerRanking by @Chinwendu20 Merge btcsuite#293 & btcsuite#294 Fix typos by @vuittont60 Merge btcsuite#297 query: fix retry query case by @ziggie1984
This PR addresses an issue reported by @dajohi regarding missing imported addresses.