-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement better private key import RPC extension. #24
Comments
Add more error codes and message, reflow some doc comments.
As a workaround for issue 2), I tried the following: My idea was that I could trigger a rescan afterwards manually. But alas, there is apparently no way to trigger a rescan (see #250) By the way, after importing the keys as indicated above,
|
For completeness, here the hint from @jrick how to trigger a rescan manuall:
|
Rather than adding an extension to the legacy RPC server, these improvements should be added to the |
This only adds the dialog and will call the CreateNewWallet RPC with the decoded seed rather than a randomly-generated one. As btcwallet does not support recovering addresses and transactions for an imported seed, this feature won't work correctly and transaction history will have to be recovered after generating the same number of addresses used from the previous wallet. However, once that is implemented, this GUI feature should work as intended. The seed can be inputed using either hex or the PGP word list encoding. At the moment, no checksumming is used or removed from the input, and all bytes are considered part of the seed. If any additional data is added to a seed encoding later, the WalletSeed.DecodeAndValidateUserInput method will need to be changed to interpret this separately. Closes btcsuite#24.
wallet: add call to modify both public and private passphrases atomically
Add mobile package
The standard RPC call for importing private keys, importprivkey, has a number of issues. Namely:
An extension RPC command should be added which resolves these issues.
The text was updated successfully, but these errors were encountered: