Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod+rpcserver: bump to latest version of btcec #2218

Merged
merged 1 commit into from
Jul 23, 2024
Merged

mod+rpcserver: bump to latest version of btcec #2218

merged 1 commit into from
Jul 23, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Jul 23, 2024

@guggero guggero mentioned this pull request Jul 23, 2024
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10055905317

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 57.218%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.67%
peer/peer.go 9 73.86%
Totals Coverage Status
Change from base Build 9957391466: 0.001%
Covered Lines: 29829
Relevant Lines: 52132
💛 - Coveralls

yyforyongyu
yyforyongyu approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🤓

Roasbeef
Roasbeef approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏵️

@Roasbeef Roasbeef merged commit b161cd6 into btcsuite:master Jul 23, 2024
3 checks passed
@guggero guggero deleted the btcec-fix branch July 24, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@yyforyongyu yyforyongyu yyforyongyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guggero @coveralls @Roasbeef @yyforyongyu