Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate default liquid prune to own fragment #457

Merged

Conversation

Kukks
Copy link
Member

@Kukks Kukks commented Apr 2, 2021

This allows users who dont want to prune their liquid node to exclude the pruning fragment. (allows rescanning for utxos)

This allows users who dont want to prune their liquid node to exclude the pruning fragment. (allows rescanning for utxos)
@Kukks Kukks force-pushed the sep-prune-fromliquiddefaults branch from aa16a27 to 15cf561 Compare April 27, 2021 09:29
@maltokyo
Copy link
Contributor

maltokyo commented May 5, 2021

How big is the full liquid chain?
I am running it, but only now realise I run in pruned mode

@Kukks
Copy link
Member Author

Kukks commented May 5, 2021

How big is the full liquid chain?
I am running it, but only now realise I run in pruned mode

Not that big (10.8GB for the full data folder, fully synced with txindex=1), the main concern was that users would attempt to enable it on their existing Lunanode installs and have their servers full up on space and crash

@maltokyo
Copy link
Contributor

maltokyo commented May 5, 2021

Ah, I have fully synched and pruned. Should I just delete the volume and start again to get full tx index, (after your split in this PR goes in), or can I do that somehow retrospectively?

@Kukks
Copy link
Member Author

Kukks commented May 5, 2021

Ah, I have fully synched and pruned. Should I just delete the volume and start again to get full tx index, (after your split in this PR goes in), or can I do that somehow retrospectively?

Be careful of the wallet dir. BTCPay uses the elementsd wallet since we do not have a functional wallet solution yet for liquid(and for unblinding confidential assets).

@Kukks
Copy link
Member Author

Kukks commented May 5, 2021

Yes, deleting the dir should be enough (though my or does not add in txindex, it would need to be a separate fragment)

@maltokyo
Copy link
Contributor

maltokyo commented May 5, 2021

cool, thanks! I am also trying to work out how to do a peg-in on my own server. Unrelated, but cannot find any info on how to do that, other than an old issue where you documented a bunch of stuff.

@Kukks
Copy link
Member Author

Kukks commented May 5, 2021

cool, thanks! I am also trying to work out how to do a peg-in on my own server. Unrelated, but cannot find any info on how to do that, other than an old issue where you documented a bunch of stuff.

need to look into that but it will require hooking liquid to the btc node and some additional configs (and probably not be able to run btc in pruned mode)

@maltokyo
Copy link
Contributor

maltokyo commented May 5, 2021

Ah, ok. That's why I enabled it, to do my on peg-ins (such a weird word, has strange connotations..), or at least try.
I do have a full tx index and non-pruned node, so I can test if you find out.

@Kukks Kukks requested a review from NicolasDorier May 11, 2021 07:58
@NicolasDorier NicolasDorier merged commit 92d9d84 into btcpayserver:master May 26, 2021
tiero added a commit to nestpay/btcpayserver-docker that referenced this pull request Dec 20, 2021
* update dogecoin (btcpayserver#483)

* chore: bump thunderhub (btcpayserver#479)

* Update doc

* Bump GRS Core and c-lightning (btcpayserver#484)

* Bump GRS Core and c-lightning

* Update eclair

* Update BitCore version to 0.90.9.10 (btcpayserver#474)

Co-authored-by: dalijolijo <dalijolijo@v220200132547106119.bestsrv.de>

* Separate default liquid prune to own fragment (btcpayserver#457)

This allows users who dont want to prune their liquid node to exclude the pruning fragment. (allows rescanning for utxos)

* opt-*-memory supported by doge

* Upgrade Sphinx Relay to v2.1.3

* S3 backup provider (btcpayserver#438)

* Add S3 backup provider

Allows upload to S3

* Update backup.sh

* Update backup.sh

Co-authored-by: britttttk <39231115+britttttk@users.noreply.github.com>

* Update backup.sh

Co-authored-by: britttttk <39231115+britttttk@users.noreply.github.com>

* Update tor

* Revert "Update tor"

This reverts commit 365e990.

* Revert "Revert "Update tor""

This reverts commit a770141.

* bump transmuter

* Add Tallycoin Connect fragment

* Update to latest tallycoin_connect version

* Finalize Tallycoin Connect integration

* Add fragment to enable LND watchtower client

* Add opt-lnd-wtclient fragment description in README

* Add ability to customize watchtower sweep fee

* remove quotes from wtclient fragment

* Save LND_WTCLIENT_SWEEP_FEE to environment file

* Bump BTCPay/NBX (btcpayserver#505)

* Bump LND to v0.13.1-beta-withloop (btcpayserver#506)

* bump Clightning to 0.10.1 (btcpayserver#507)

* Update doc

* Revert "Bump LND to v0.13.1-beta-withloop (btcpayserver#506)"

This reverts commit 7574612.

* Hotfix for problems with LND 0.13.1 (btcpayserver#508)

* Revert "Revert "Bump LND to v0.13.1-beta-withloop (btcpayserver#506)""

This reverts commit b9777f9.

* Fetching version that waits for proper wallet unlock state before proceeding

* bump

* Bump RTL and Clightning-rest

Only for clightning, separate PR for lnd

* Update docker builder

* chore: update to dash 0.17.0.3 (btcpayserver#509)

* chore: update to dash 0.17.0.3

* chore: update dash.conf defaults

* Bump RTL

* Update Tallycoin Connect to v1.4.0

* Update Sphinx Relay to v2.2.0

* bump btcpay

* Update NBX

* Update liquid.yml

* bump nbx

* bump nbx

* Update bitcoin-clightning.yml

* bump nnbx

* bump nbx

* bump nbx

* Bump btcpay

* Revert "Bump btcpay"

This reverts commit 64fe7db.

* Revert "Revert "Bump btcpay""

This reverts commit 40f2765.

* Bump RTL

* bump nbx

* bump

* New utxo-set for FastSync

* Bump Monero to v0.17.2.3 (btcpayserver#522)

Co-authored-by: Seth Simmons <sethsimmons@users.noreply.github.com>
Co-authored-by: Seth Simmons <sethsimmons@pm.me>
Co-authored-by: Seth Simmons <ssimmons2@theark.cloud>

* Bump NBX (btcpayserver#528)

* Update FastSync sig for 699714 and testnet (btcpayserver#532)

* Update signature for fastsync (btcpayserver#526)

* Provide plugin directory for Clightning (btcpayserver#518)

* Make btcpay-restart properly restart everything (Fix btcpayserver#524)

* Update nbx

* Update bitcoin-clightning.yml

* Bumping RTL to 0.11.2 due to bug with peering (btcpayserver#523)

* Script fix (btcpayserver#520)

* Feat/fireflyiii (btcpayserver#344)

* Adding Firefly-iii opt fragment

* Adding environment variable to force creation of db

* Instructing postgres to create database

* Switching exposing default port, running create db command

* Remove grep command for postgres container

* Removing database creation on postgres container start

* Adding required App Key env variable

* Updating nginx rewriting

* Updating firefly nginx confugration traying to make it work with subdirectory

firefly-iii/firefly-iii#2848 (comment)

* Trying to rewrite

* Reconfiguring nginx to pass headers

* Updating docker fragment

* Last try

* Allowing firefly iii to be hosted on other domain

* Fixing docker compose env variables

* Exposing ports for external communication

* Ports exposing

* Updating firefly host reference

* Matching service name and VIRTUAL_HOST_NAME

* Getting nginx to redirect to port 8080

* update and adapt

* Adapt firefly to be with dedicated domain

* Adapt Docker file builder to support non github builds

* Make firefly init create db only if not exists + run full recommended upgrade procedure

Co-authored-by: rockstardev <rockstardev@users.noreply.github.com>

* Update dogecoin.yml (btcpayserver#533)

* Set Default ACME production

* Update Lightning-Rest

* bump btcpay

* Revert "Provide plugin directory for Clightning" (btcpayserver#535)

* Bump Bitcoin core

* Add joinmarket support

* Activate gzip

* Upgrade postgres

* Fix firefly link

* Fix instructions link for docs

* Fix video link and preview image for docs

* Markdown formatting

* Revert "Upgrade postgres"

This reverts commit 9741499.

* Revert "Revert "Upgrade postgres""

This reverts commit d321c09.

* Warning

* Use supervisord for joinmarket

* Fix jm.sh doc

* Fix doc

* Fix doc

* Handle postgres migration for old install

* Do not parse settings.json

* Fix postgres update for arm32

* Fix postgres update for arm7

* Add documentation if postgres update fail on rapsberry pi 4

* Update woocommerce

* Bump Tor Relay to latest stable release (4.5.9)

* Add joinmarket for arm64 and arm32

* Improve NDLC disclaimer (btcpayserver#538)

* Add chatwoot support system (btcpayserver#353)

Co-authored-by: Andrew Camilleri <kukks@btcpayserver.org>

* Bump transmuter

* Revert "Bump transmuter"

This reverts commit 8280398.

* bump bitcoin core 22.0, fix issue about corrupt settings.json

* Revert "bump bitcoin core 22.0, fix issue about corrupt settings.json"

This reverts commit a092054.

* Revert "Revert "bump bitcoin core 22.0, fix issue about corrupt settings.json""

This reverts commit dcf0e55.

* Remove bitcoin taproot cc

* Bump NBX

* Bump joinmarket to fix receive-payjoin

* Bump joinmarket to fix receive-payjoin

* Upgrade Tallycoin Connect (btcpayserver#541)

Now it also supports arm32v7 and arm64v8 architectures.

* update doc

* Bump LND to v0.13.3-beta (btcpayserver#540)

* Switch to our own postgres container

* Update jm

* update postgres

* bump postgres

* bump postgres

* bump nbxplorer

* bump

* Make sure only one lightning implementation is selected

* bump btcpay

* Bump ThunderHub version (btcpayserver#547)

* Upgrade Tallycoin Connect (btcpayserver#541)

* Upgrade Tallycoin Connect

Now it also supports arm32v7 and arm64v8 architectures.

* Correct Dockerfile repo

* Add images to Docker file builder helper

* Fix GitHub link

* Automatically update libseccomp2 on rapsberry pi 4

* Bump BTCPay

* bump BTCPay

* Update opt-add-btctransmuter.yml

* Update libseccomp2 on any arm32 buster hosts

* bump btcpay

* update NBXplorer

* bump btcpay

* bump LND and BTCPay

* bump lnd

* bump clightning

* bump woocommerce

* Add Lightning Terminal fragment (btcpayserver#512)

* Add Lightning Terminal fragment

* Remove mappings and variables

* Version update

* Update contrib/build-all-images.sh

Co-authored-by: Oliver Gugger <gugger@gmail.com>

* Update docker version

* Add Lightning Terminal to fragments list

* Upgrade LiT to v0.6.0

Co-authored-by: Oliver Gugger <gugger@gmail.com>

* Update Litecoin

* fix litecoin

* Update EPS

* Bump monacoin to 0.20.2 (btcpayserver#563)

* Update Lightning Terminal (btcpayserver#562)

Co-authored-by: Andrew Camilleri <kukks@btcpayserver.org>

* bump btcpay

* bump liquid

Co-authored-by: Mike Olthoff <mike@olthoff.ca>
Co-authored-by: Anthony Potdevin <31413433+apotdevin@users.noreply.github.com>
Co-authored-by: nicolas.dorier <nicolas.dorier@gmail.com>
Co-authored-by: gruve-p <gruve-p@users.noreply.github.com>
Co-authored-by: Dali <37987466+dalijolijo@users.noreply.github.com>
Co-authored-by: dalijolijo <dalijolijo@v220200132547106119.bestsrv.de>
Co-authored-by: Andrew Camilleri <kukks@btcpayserver.org>
Co-authored-by: Dennis Reimann <mail@dennisreimann.de>
Co-authored-by: Patrick <privat@skyraptor.eu>
Co-authored-by: britttttk <39231115+britttttk@users.noreply.github.com>
Co-authored-by: Richard Safier <richardj@safier.com>
Co-authored-by: rockstardev <5191402+rockstardev@users.noreply.github.com>
Co-authored-by: Kukks <evilkukka@gmail.com>
Co-authored-by: strophy <32928115+strophy@users.noreply.github.com>
Co-authored-by: Seth Simmons <sethsimmons@protonmail.com>
Co-authored-by: Seth Simmons <sethsimmons@users.noreply.github.com>
Co-authored-by: Seth Simmons <sethsimmons@pm.me>
Co-authored-by: Seth Simmons <ssimmons2@theark.cloud>
Co-authored-by: Jonathan Underwood <junderwood@bitcoinbank.co.jp>
Co-authored-by: Downet <78277193+downet@users.noreply.github.com>
Co-authored-by: rockstardev <rockstardev@users.noreply.github.com>
Co-authored-by: Mike Olthoff <mike@stufftech.io>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: xpayserver <67416048+xpayserver@users.noreply.github.com>
Co-authored-by: Oliver Gugger <gugger@gmail.com>
Co-authored-by: Jin Eguchi <wakiyamap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants