Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPDoc #851

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Fix PHPDoc #851

merged 1 commit into from
Sep 15, 2017

Conversation

maxailloud
Copy link

Basically just some PHPDoc fix.

@bshaffer
Copy link
Owner

Dumb question, is the leading \ necessary? I assume the answer is PHPDoc reads from the same namespace as the executing PHP code does, and since we don't have a use statement and we are in a different namespace, PHPDoc sees this as \OAuth2\Controller\OAuth2\GrantType\ClientCredentials (for instance)

@maxailloud
Copy link
Author

In PHPStorm not putting the leading \ gives me an error.
And rightfully as the class \OAuth2\Controller\OAuth2\GrantType\ClientCredentials doesn't exist, but \OAuth2\GrantType\ClientCredentials does.

@bluebaroncanada
Copy link
Collaborator

If you use use, you don't need the preceding \.

@maxailloud
Copy link
Author

Yes but importing a class just for the PHPDoc is pointless.
It's just updating the namespace of the classes use in the PHPDoc to have the real namespace.

@bluebaroncanada
Copy link
Collaborator

Yeah. Sorry. I think that made some of you think that I actually care. :p

@bshaffer bshaffer merged commit 7316242 into bshaffer:develop Sep 15, 2017
bshaffer pushed a commit that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants