Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust type hint for Symfony 6 #1030

Merged
merged 1 commit into from
Oct 12, 2022
Merged

adjust type hint for Symfony 6 #1030

merged 1 commit into from
Oct 12, 2022

Conversation

araab
Copy link
Contributor

@araab araab commented Sep 4, 2022

related to bshaffer/oauth2-server-httpfoundation-bridge#42

fixes the following errors:

Declaration of OAuth2\HttpFoundationBridge\Response::setStatusCode(int $statusCode, ?string $text = null): static must be compatible with OAuth2\ResponseInterface::setStatusCode($statusCode)
public function setStatusCode(int $statusCode); in ResponseInterface and OAuth\Response.php 

@bshaffer bshaffer merged commit cd11527 into bshaffer:master Oct 12, 2022
@bshaffer
Copy link
Owner

Tests passed in #1034 (not sure why they didn't run here)

Thanks for this!

@bshaffer
Copy link
Owner

We've released v1.7, so this should now be resolved! Thanks for submitting those!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants