Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a default value followed by a required parameter is deprecated in PHP8 #39

Merged
merged 1 commit into from
Apr 26, 2022
Merged

a default value followed by a required parameter is deprecated in PHP8 #39

merged 1 commit into from
Apr 26, 2022

Conversation

araab
Copy link
Contributor

@araab araab commented Feb 6, 2022

Fixes #38

If a parameter with a default value is followed by a required parameter, the default value has no effect. This is deprecated as of PHP 8.0.0 and can generally be resolved by dropping the default value, without a change in functionality

https://www.php.net/manual/en/migration80.deprecated.php

@doctorby
Copy link

doctorby commented Apr 4, 2022

Hi @bshaffer
Can you merge it, please?

@bshaffer bshaffer merged commit 7556943 into bshaffer:master Apr 26, 2022
@bshaffer
Copy link
Owner

released in https://github.com/bshaffer/oauth2-server-httpfoundation-bridge/releases/tag/v1.6

@doctorby

@araab araab deleted the fix-deprecation-notice branch April 27, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.0 deprecation notice
3 participants
@araab @doctorby @bshaffer