Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to read out the Kamstrup Multical 21 water meter using the optical eye from https://wiki.volkszaehler.org/hardware/controllers/ir-schreib-lesekopf (I used the USB version).
Notes about the multical 21 interface:
0x80 ...
) is fed back to the sender first, and needs to be ignored before processing the actual response (0x40 ...
). This seems different from the other Kamstrup devices already supported (as the code did not seem to be able to handle that).Open points:
CRC of the response seems not to be correct. This does not matter, as we dont need it, but is still strange. It might indicate a problem with the CRC calculation.All comments welcome. I tried to stay as close as possible to the original code, with the exception of factoring out the common code between
readvar
andreadvar_multiple
into a newprocess_response
function.