Test transformations #217
Merged
Test transformations #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerManNav
added
bug
|
Did you find a bug? |
jofrevalles
approved these changes
Oct 9, 2024
mofeing
requested changes
Oct 9, 2024
test/Transformations_test.jl
Outdated
| @@ -154,13 +152,32 @@ | |||
|
|
|||
| # Test that the resulting tn contains no tensors with larger rank than the original | |||
| rank = length ∘ size ∘ parent | |||
| @test max(rank(tensors(reduced)) == max(rank(tensors(tn)))) | |||
| @test max(rank.(tensors(reduced))...) <= max(rank.(tensors(tn))...) | |||
There was a problem hiding this comment.
Would you mind deleting rank and replacing it for ndims?
There was a problem hiding this comment.
Also it's better if you call maximum: the same as max but without variadic arguments and can use some map.
Suggested change
| @test max(rank.(tensors(reduced))...) <= max(rank.(tensors(tn))...) | |
| @test maximum(ndims, tensors(reduced)) <= maximum(ndims, tensors(tn)) |
test/Transformations_test.jl
Outdated
|
|
||
| # Test that the resulting tn contains <= tensors than the original | ||
| @test length(tensors(reduced)) == 1 | ||
| @test length(tensors(reduced)) <= length(tensors(tn)) |
There was a problem hiding this comment.
Can you replace length(tensors(...)) for Tenet.ntensors?
There was a problem hiding this comment.
Suggested change
| @test length(tensors(reduced)) <= length(tensors(tn)) | |
| @test Tenet.ntensors(reduced) <= Tenet.ntensors(tn) |
There was a problem hiding this comment.
tensors needs to create a Vector where it copies all the Tensors while ntensors doesn't: it just queries the inner Dict
There was a problem hiding this comment.
@jofrevalles it might be worth checking if that by @inlineing tensors and inds, it can optimize away the Vector creation.
test/Transformations_test.jl
Outdated
| # Options (for non-recursive) | ||
| # Test that a non-recursive contraction is an intermediate simplification | ||
| reduced_nonrecursive = transform(tn, ContractSimplification(:length, false)) | ||
| @test length(tensors(tn)) > length(tensors(reduced_nonrecursive)) > length(tensors(reduced)) |
There was a problem hiding this comment.
Suggested change
| @test length(tensors(tn)) > length(tensors(reduced_nonrecursive)) > length(tensors(reduced)) | |
| @test Tenet.ntensors(tn) > Tenet.ntensors(reduced_nonrecursive) > Tenent.ntensors(reduced) |
test/Transformations_test.jl
Outdated
|
|
||
| # 2nd-stage simplification result in full simplification for this TN | ||
| reduced_full = transform(reduced_nonrecursive, ContractSimplification(:length, false)) | ||
| @test length(tensors(reduced)) == length(tensors(reduced_full)) |
There was a problem hiding this comment.
Suggested change
| @test length(tensors(reduced)) == length(tensors(reduced_full)) | |
| @test Tenet.ntensors(reduced) == Tenet.ntensors(reduced_full) |
test/Transformations_test.jl
Outdated
| # Options (minimization by rank) | ||
| # Test that the resulting tn contains no tensors with larger rank than the original | ||
| reduced_byrank = transform(tn, ContractSimplification(:rank, true)) | ||
| @test max(rank.(tensors(reduced_byrank))...) <= max(rank.(tensors(tn))...) |
There was a problem hiding this comment.
Suggested change
| @test max(rank.(tensors(reduced_byrank))...) <= max(rank.(tensors(tn))...) | |
| @test maximum(ndims, tensors(reduced_byrank)) <= maximum(ndims, tensors(tn)) |
test/Transformations_test.jl
Outdated
| @test max(rank.(tensors(reduced_byrank))...) <= max(rank.(tensors(tn))...) | ||
|
|
||
| # Test that the resulting number of tensors is bigger for a reduction by rank than for length | ||
| @test length(tensors(reduced_byrank)) > length(tensors(reduced)) |
There was a problem hiding this comment.
Suggested change
| @test length(tensors(reduced_byrank)) > length(tensors(reduced)) | |
| @test Tenet.ntensors(reduced_byrank) > Tenet.ntensors(reduced) |
mofeing
reviewed
Oct 10, 2024
test/Transformations_test.jl
Outdated
Comment on lines
154
to
155
| rank = length ∘ size ∘ parent | ||
| @test max(rank(tensors(reduced)) == max(rank(tensors(tn)))) | ||
| @test maximum(ndims, tensors(reduced)) <= maximum(ndims, tensors(tn)) |
There was a problem hiding this comment.
Remove the rank definition and it should be done
mofeing
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.