Fixes JSObject(null) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized after submitting this that I didn't rig up the unit tests to the test site. Go ahead and rig that up how you see fit. Seems like Javascript interop tests need their own category since it's outside the scope of normal python. |
|
Hi James, I merged this pull request, but I realize I shouldn't have : like CPython, JSObject(null) should raise a NameError exception if no variable called "null" was defined in the Python code |
PierreQuentel
pushed a commit
that referenced
this pull request
Feb 9, 2017
Fix --modules option of brython.py
PierreQuentel
pushed a commit
that referenced
this pull request
Sep 10, 2017
added some stuff to _float_info to make it work
PierreQuentel
pushed a commit
that referenced
this pull request
Jan 28, 2019
Added a test for possibly undefined argument
PierreQuentel
pushed a commit
that referenced
this pull request
Apr 10, 2019
PierreQuentel
pushed a commit
that referenced
this pull request
Oct 22, 2019
Just merging my section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was noticing that JSObject(null) was returning a JSObject instead of simply a NoneType, resulting in comparison failures.