-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orcidlink.sty binding #2395
base: master
Are you sure you want to change the base?
orcidlink.sty binding #2395
Conversation
56c77a0
to
97aebd5
Compare
Would you be willing to also add a small test? Maybe at And it can depend on the sty file having been installed in latexml_tests("t/graphics",
requires=>{colors=>'dvipsnam.def',
xcolors=>'dvipsnam.def',
orcidlink=>'orcidlink.sty'}); |
The test would hardcode the specific SVG produced by the current version of orcidlink. Would that cause problems in the future, should orcidlink modify the logo (unlikely!)? |
We may need to update it if/when such transitions happen, which shouldn't be too painful. Probably a small price to pay, so that we also get notified if some future internal change breaks the expected sty load. |
Ok, the test is not feasible because TL2021 and later have different implementations. I have updated the binding to make the TL2021 version work, but I have found a major issue with all versions: when |
The testing harness already has a nice technique to specify a minimal texlive version. Checking this test only for the latest texlive should be fine. That is possible via: requires=>{ #...
orcidlink => {packages => 'orcidlink.sty', texlive_min => 2021}} Figuring out what happens in the In earlier latexml decades I would even be tempted to suggest hardcoding the expected SVG in the Perl binding as a DefConstructor, to guarantee robustness. That used to be common when we had no other easy path forward. But best to check if the raw interpretation can't be fixed first. I'll try to take a look. |
Fix #2386 partially. orcidlink.sty can be read raw (after adding
\XeTeXLinkBox
to hyperref), except that:\fontcharht
is not implemented (yet?), so I temporarily redefine it with a hardcoded valueFurthermore, the ORCiD logo does not actually resize and is misaligned because the
@viewBox
attribute is missing, but that will be solved once #2376 is fixed.