Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use em rather than percent for MathML mo minsize, maxsize #2341

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

brucemiller
Copy link
Owner

Use em rather than percent for MathML mo minsize, maxsize to avoid interpretation issues.

Also, tweak operator dictionary assumptions about what browsers will assume is stretchy.

@brucemiller brucemiller requested a review from dginev March 28, 2024 13:48
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

The only part to wonder out loud is whether we'll encounter less issues with the em formulation compared to the % formulation.

Now that there is traction to correct the % behavior to match MathML 3, I remember you mentioned that theoretically that behavior is more accurate. But that assumes perfect implementations...

@brucemiller
Copy link
Owner Author

Actually, I'm not sure if % is theoretically more accurate than em. In practice, em is.

As far as "encounter(ing) more issues"; well, other issues may be more apparent. Currently Safari ignores %, so essentially treats it as stretchy, which comes out looking reasonable even if it wasn't the author's intention. However, with ems, Safari seems to quantize the size in an odd way, so sometimes it doesn't look as intended either. Chrome's % tends to produce extremely large fences; with ems they come out in the correct size, but sometimes that seems to accentuate the symmetric bug. So one could make a strategy based on which bugs they expect to be fixed when?

@brucemiller brucemiller merged commit 02b7fed into master Apr 2, 2024
26 checks passed
@brucemiller brucemiller deleted the maxsize-percent branch April 2, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants