Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid unexpected division by zero in image transform #2333

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

dginev
Copy link
Collaborator

@dginev dginev commented Mar 1, 2024

Fixes an unfortunate Fatal in arXiv:0710.5511

It is also curious to note that some diagnostic "die" messages from perl in post-processing go unnoticed in the arXiv build logs, as they do not use the latexml error-reporting API. So this paper was in the "no_messages" category. As in:

Illegal division by zero at /home/deyan/perl5/lib/perl5/LaTeXML/Util/Image.pm line 225.
Status:conversion:3

I also tracked down the underlying reason for the bug, which was a malformed viewport option - there was a missing ToString for serializing the optional argument of \epsfbox from epsf.sty.ltxml. I also noticed this macro is used in epsfig.sty.ltxml, but decided not to touch that in this PR.

@brucemiller brucemiller merged commit 38e663d into brucemiller:master Apr 1, 2024
13 checks passed
@brucemiller brucemiller deleted the another-division-by-zero branch April 1, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants