Framed fix #2161
Merged
Framed fix #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Positionable.attributes) where they make more sense
dginev
approved these changes
Jul 24, 2023
| @@ -4695,7 +4695,7 @@ DefMacro('\framebox', '\@ifnextchar(\pic@framebox\@framebox', robust => 1); | |||
| DefConstructor('\@framebox[Dimension][]{}', | |||
| "?#mathframe(<ltx:XMArg enclose='box'>#inner</ltx:XMArg>)" | |||
| . "(<ltx:text ?#width(width='#width') ?#align(align='#align')" | |||
| . " framed='rectangle' framecolor='#framecolor'" | |||
| . " framed='rectangle' framecolor='#framecolor' cssstyle='#cssstyle'" | |||
There was a problem hiding this comment.
I am spiritually obliged to mention css_style looks better on every PR that uses the non-underscore variant :>
There was a problem hiding this comment.
css_style??? so boring...
| <td align="left"><text backgroundcolor="#FF0000" class="ltx_phantom" font="sansserif" fontsize="90%" framecolor="black" framed="rectangle">XX</text><text font="sansserif" fontsize="90%"> 0 1 1</text></td> | ||
| <td align="left"><text backgroundcolor="#FF0000" class="ltx_phantom" font="sansserif" fontsize="90%" framecolor="black" framed="rectangle">XX</text><text font="sansserif" fontsize="90%"> FF0000</text></td> | ||
| <td align="left"><text backgroundcolor="#4D4D4D" class="ltx_phantom" font="sansserif" fontsize="90%" framecolor="black" framed="rectangle">XX</text><text font="sansserif" fontsize="90%"> 0.3</text></td> | ||
| <td align="left"><text backgroundcolor="#FF0000" class="ltx_phantom" cssstyle="padding:0.0pt" font="sansserif" fontsize="90%" framecolor="black" framed="rectangle">XX</text><text font="sansserif" fontsize="90%"> 1 0 0</text></td> |
There was a problem hiding this comment.
Quickly marking that the test using ltx_phantom text now gets explicit 0 padding.
Probably intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
framedattribute, vsltx_framedCSS a bit more consistently, allows for adjusting the frame separation, and avoids collapsing nodes which have framing.Fixes #2134
Fixes #2135