Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Added in Auto Save on Focus Lost #251

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Added in Auto Save on Focus Lost #251

merged 2 commits into from
Jan 18, 2019

Conversation

stolksdorf
Copy link
Contributor

Added a toggle-able option to automatically save the file if Abricotine loses focus.

  • Will only save if the file has a valid path
  • Added the toggle to the file menu
  • This setting is defaulted to false
  • Uses the internal save method so it doesn't interrupt the file watcher

Before submitting your PR please make sure:

  • You worked on the develop branch (or any other branch which was forked from develop),
  • Your PR is not targeting the master branch,
  • You tested your code and it works.

Copy link
Owner

@brrd brrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good.
I only have one request before merging this PR (see my comment)

app/menu-window.json Outdated Show resolved Hide resolved
@stolksdorf
Copy link
Contributor Author

Good catch! Missed that when I was figuring out the config originally. Great source code btw, I was able to jump in and figure out how to make my change in under 20min.

@brrd brrd merged commit 30f8321 into brrd:develop Jan 18, 2019
@brrd
Copy link
Owner

brrd commented Jan 18, 2019

👍

@brrd
Copy link
Owner

brrd commented Feb 15, 2019

FYI I added some changes to this feature in d44bda5.
The autosave is now triggered when the document changes (and not on the "blur" event anymore).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants