Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Monospaced Headings & Code by default #232

Merged
merged 4 commits into from
Feb 13, 2018
Merged

Monospaced Headings & Code by default #232

merged 4 commits into from
Feb 13, 2018

Conversation

GladOSkar
Copy link
Contributor

Hi,
first of all - love the editor!

I think the titles, headings and code should also use Fira Code by default.

Advantages:

  • Consistency
  • Titles line up when using underline notation (see below)
  • Fira Code Markdown-specific ligatures are used (Connected Octothorpes)
  • Actual Code benefits from Code-specific ligatures (duh)

Disadvantages

  • ???

Thank You for this great editor!

@brrd
Copy link
Owner

brrd commented Feb 12, 2018

Well, I find the presentation much clearer when two different font are used, but why not, after all.

But please don't change the other font faces, so user can keep the previous styles when Fira Code is not installed.

In other words, please do this in .editor-headers():

font-family: "Fira Code", "Lucida Sans", "Lucida Grande", "Lucida Sans Unicode", "Luxi Sans", sans-serif;

instead of this:

font-family: "Fira Code", Monaco, "DejaVu Sans Mono", "Lucida Console", "Andale Mono", monospace;

@GladOSkar
Copy link
Contributor Author

I thought monospaced was generally better because then these underlines line up:

image

image

But if you still want it the way you said... I will do so :)

@brrd
Copy link
Owner

brrd commented Feb 12, 2018

There is no need to use a specific number of -/= symbols in headers, so I don't think this is important (and I personally totally disagree with this underlinish headers syntax, which is a real pain to parse in markdown).

If you don't mind please keep the sans-serif fallback fonts. Users can still customize their styles if they really want the headers font to be monospaced.

@GladOSkar
Copy link
Contributor Author

OK then... If you want me to rebase those commits then that will have to wait a day since my main computer died yesterday.

Cheers :)

@brrd brrd merged commit 31bdebd into brrd:develop Feb 13, 2018
@brrd
Copy link
Owner

brrd commented Feb 13, 2018

It's merged. Thank you!

@GladOSkar GladOSkar deleted the patch-1 branch February 13, 2018 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants