OSX version cannot open new file after closing window

[terry182]

This error message pop up when trying to open new files after closing the old windows.

Uncaught Exception:
TypeError: Cannot read property 'webContents' of undefined
at sendCommand (/opt/homebrew-cask/Caskroom/abricotine/0.2.2/Abricotine.app/Contents/Resources/app.asar/app/abr-menu.js:29:16)
at /opt/homebrew-cask/Caskroom/abricotine/0.2.2/Abricotine.app/Contents/Resources/app.asar/app/abr-menu.js:37:42
at MenuItem.click (/opt/homebrew-cask/Caskroom/abricotine/0.2.2/Abricotine.app/Contents/Resources/atom.asar/browser/api/lib/menu-item.js:56:20)
at Function.delegate.executeCommand (/opt/homebrew-cask/Caskroom/abricotine/0.2.2/Abricotine.app/Contents/Resources/atom.asar/browser/api/lib/menu.js:125:71)

[brrd]

I need more informations about this behaviour.
Did you close all the windows before opening a new document or just some of them?
Is the app still running after you close all the windows?
If it is, can you see its menu bar?

[terry182]

I closed all the windows. The app is still runing when the error occurs and the menu bars still there.

The error also occurs when opening existing files.

[brrd]

OK, so this is related to OS X behaviour.
Abricotine is supposed to exit when you close its last window, but on OS X applications remain open until you exit, even if all windows are closed. I guess that we need to rethink the way Abricotine manages its menu.
Thanks for reporting.

[brrd]

I guess 088df47 should fix this issue but I need someone to test it on OSX please. You will have to build Abricotine from the osx-menu branch.

Expected behaviour: when all windows are closed, the menubar should be updated in order to provide fewer menu items. Please make sure that all menu items are working well when clicked from here.
When a new window is opened, the menu bar should provide all items again.

[nloveladyallen]

When the last window is closed, the menus change as you have said should happen. When attempting to open a new window, the same error occurs, with slightly different line numbers (presumably due to incidental changes to the relevant files).

I will also note that menus on OS X do not usually change depending on whether there is a window open. If a menu is no longer relevant, all its options will become greyed out, but it still appears in the menu bar.

[brrd]

@nloveladyallen Thank you. So I'll keep working on it.

[brrd]

This should be fixed with a642a9e

If a menu is no longer relevant, all its options will become greyed out, but it still appears in the menu bar.

So we moved to this behaviour in d5d020c

Could someone give me feedback please? You can try it by building the app from osx-menu branch. Thanks.

[nloveladyallen]

The menus no longer change, and regular items are greyed out. Submenus still show up with their options greyed out, while typically apps grey out the submenu entirely (hovering does nothing).

There is now a different error when opening a new window after closing the last one:

Uncaught Exception:
TypeError: abrApp.open is not a function
at Object.commands.new (/Users/noah/src/Abricotine/dist/Abricotine-darwin-x64/Abricotine.app/Contents/Resources/app.asar/app/commands-main.js:15:16)
at AbrApplication.execCommand (/Users/noah/src/Abricotine/dist/Abricotine-darwin-x64/Abricotine.app/Contents/Resources/app.asar/app/abr-application.js:126:30)
at /Users/noah/src/Abricotine/dist/Abricotine-darwin-x64/Abricotine.app/Contents/Resources/app.asar/app/abr-menu.js:33:42
at MenuItem.click (/Users/noah/src/Abricotine/dist/Abricotine-darwin-x64/Abricotine.app/Contents/Resources/atom.asar/browser/api/lib/menu-item.js:56:20)
at Function.delegate.executeCommand (/Users/noah/src/Abricotine/dist/Abricotine-darwin-x64/Abricotine.app/Contents/Resources/atom.asar/browser/api/lib/menu.js:125:71)

[brrd]

OK, thank you.

[brrd]

Could you try it again please?

typically apps grey out the submenu entirely (hovering does nothing)

I don't know how to do this with electron (I'm not even sure it's possible) so in this last revision menus are simply removed when all their items are disabled.

Thanks.

[nloveladyallen]

Closing the last window and creating a new document or opening a document now works correctly.

I feel it is more disorienting to have the menus disappear than have the submenus still show as active, and that the way it worked as of d5d020c is best. It may not be possible to disable a submenu with Electron; Atom leaves submenus active as well.

[brrd]

@nloveladyallen thanks

I feel it is more disorienting to have the menus disappear than have the submenus still show as active, and that the way it worked as of d5d020c is best.

OK, I will revert e6e97dd

[brrd]

Done and merged osx-menu into develop.