Fix EPERM on windows #156
Closed
Fix EPERM on windows #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempting to fix EPERM on windows, #83
|
I'm not sure what to make of this with so many comments. What's the verdict on this patch? |
|
The comments above don't apply to this patch, because Larzans was requiring watchify, not running it from the command line. (And this patch only modifies cmd.js.) This patch was working on my computer, but I found out recently, that under certain conditions, I am still able to replicate the bug. So, unfortunately, this patch doesn't totally fix the bug. I'll make a new PR if I figure this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83.
If it gets an EPERM error when renaming, it will copy the dotfile to the outfile and delete the dotfile, effectively renaming it.
Edit: The comment chain below is outdated.