Update index.js #152
Closed
Update index.js #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug with JSON requires from JS files not being modularised cleanly.
|
I don't know what the side effects are, but this solves the issue I'm running into. |
|
It definitely breaks grunt-browserify, sadly. |
|
@Pleochism any idea what the underlying issue is? and why this change solves it? |
|
I don't. I'd guess that it's related to caching of files, but I can't determine what the cache/packageCache properties are used for further up the chain. Unfortunately I won't have time to look at this again for a few days. |
|
@Pleochism @kumavis Can you try |
|
Yep, that did the trick. Works as expected via grunt-browserify as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug with JSON requires from JS files not being modularised cleanly.