Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] fix posttest script on Windows #332

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

targos
Copy link
Contributor

@targos targos commented Dec 29, 2024

Use double quotes in cmd argument.
Resolve deprecation warning for --production.

Closes: #331

Use double quotes in cmd argument.
Copy link

socket-security bot commented Dec 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

This comment was marked as off-topic.

package.json Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Dec 30, 2024

Also, appveyor continues to pass (and fail) just like it does on main. Is there some kind of appveyor test we can add that would have caught this?

@targos
Copy link
Contributor Author

targos commented Dec 30, 2024

The other more simple solution is to remove posttest from the citgm config

@ljharb
Copy link
Member

ljharb commented Dec 30, 2024

while that's also a fine citgm workaround, it'd be nice if windows contributors could run the tests locally :-)

@targos
Copy link
Contributor Author

targos commented Dec 30, 2024

Also, appveyor continues to pass (and fail) just like it does on main. Is there some kind of appveyor test we can add that would have caught this?

appveyor doesn't run the posttest script:

resolve/appveyor.yml

Lines 70 to 81 in cf4ee88

# Post-install test scripts.
test_script:
# Output useful info for debugging.
- node --version
- npm --version
# run tests
- cd
- npm run tests-only
- 'subst X: ..'
- 'cd /d X:\resolve'
- cd
- npm run tests-only

it'd be nice if windows contributors could run the tests locally

npm test still fails on Windows because of the prelint script which uses bash-specific syntax (I won't fix it)

@ljharb
Copy link
Member

ljharb commented Dec 30, 2024

Gotcha, this is fine as-is then. Thanks!

@ljharb ljharb changed the title test: fix posttest script on Windows [Tests] fix posttest script on Windows Dec 30, 2024
@ljharb ljharb merged commit 32b51a5 into browserify:main Dec 30, 2024
366 of 367 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail to run on Windows
2 participants