-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#83 fix for Opera 10.x #84
Conversation
@zertosh, @goto-bus-stop could one of you please merge this pull request? |
@goto-bus-stop could you please also merge my pull request? It doesn't affect any other browser and would help me a lot. |
Btw: I just realized that the testling.ci status image links to a wrong URL: |
will try to get to it tonight, got some other work to do first :) sorry for leaving this hanging |
No problem - I know that feeling way too well ;) |
Hmm opera 10 seems to be in very very low use according to this browser usage table. I don't know how different those numbers would be accounting for older smart tvs (or whether they are already represented), but I'd rather not add more bytes to every browserify bundle to support old browsers if it can be avoided. Would specifying a custom prelude be an option for you? Options passed to the browserify({
prelude: fs.readFileSync('./opera10-prelude.js', 'utf8'),
preludePath: path.join(__dirname, './opera10-prelude.js')
}) |
The problem is that the standard statistics only measure desktop and mobile browsers. No SmartTVs. |
The added cost of another function wrap is negligible; the cost of breaking in any browser, no matter how little-used, is high. I’d love to see this land. |
released in 6.0.4; thanks for bringing this up @philippsimon & for sharing the info about smart tv standards! |
Great - thanks a lot!! |
Fix for #83