Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont require LLMClient to use stagehand #379

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Conversation

seanmcguire12
Copy link
Collaborator

@seanmcguire12 seanmcguire12 commented Jan 4, 2025

related: #368

why

  • we want users to be able to use non-ai features of stagehand without requiring them to set up an LLM client

what changed

  • only use default LLM client if they have an API key, otherwise dont pass in an LLM client & only error if they try to use AI features

test plan

  • e2e tests, evals

Copy link

changeset-bot bot commented Jan 4, 2025

🦋 Changeset detected

Latest commit: 02f8bb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kamath
Copy link
Contributor

kamath commented Jan 5, 2025

don't think existing evals are going to be enough here; can we add a simple eval in combination that tries to use stagehand without any LLM key?

Copy link
Contributor

@kamath kamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff. i like that we now remove LLM API keys from e2e altogether to test this :)

@seanmcguire12 seanmcguire12 merged commit b1c6579 into main Jan 7, 2025
10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants