Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on Python 3.10 #462

Closed
wants to merge 3 commits into from
Closed

ci: run tests on Python 3.10 #462

wants to merge 3 commits into from

Conversation

browniebroke
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #462 (0b281a2) into main (3d9851a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          27       27           
  Lines         947      947           
=======================================
  Hits          945      945           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9851a...0b281a2. Read the comment docs.

@browniebroke
Copy link
Owner Author

browniebroke commented Sep 10, 2021

The current error:

SolverProblemError

  The current project's Python requirement (3.10.0rc2) is not compatible with some of the required packages Python requirement:
    - dataclasses requires Python >=3.6, <3.7, so it will not be satisfied for Python 3.10.0rc2
  
  Because dataclasses (0.8) requires Python >=3.6, <3.7
   and no versions of dataclasses match >=0.6.0,<0.8 || >0.8, dataclasses is forbidden.
  So, because django-codemod depends on libcst (==0.3.20) which depends on dataclasses (>=0.6.0), version solving failed.

Which seems rather strange, because dataclasses is only required by libCST for Python<3.7. This is because poetry detects 3.10 as 3.1: python-poetry/poetry#4354

It will be is fixed in Poetry 1.1.8.

@browniebroke
Copy link
Owner Author

On 1.1.8, I'm getting this error: python-poetry/poetry#4210

It's fixed on 1.2.0a2, but the SolverProblemError with dataclasses is not. It's backported to master, but not yet released.

@browniebroke browniebroke deleted the ci/py-3.10 branch October 19, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant