Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref intro p tag #493

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Ref intro p tag #493

merged 8 commits into from
Jun 18, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jun 13, 2024

From issue 487

dependabot bot and others added 5 commits June 10, 2024 22:13
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.8.21 to 1.8.22.
- [Release notes](https://github.com/grpc/grpc-node/releases)
- [Commits](https://github.com/grpc/grpc-node/compare/@grpc/grpc-js@1.8.21...@grpc/grpc-js@1.8.22)

---
updated-dependencies:
- dependency-name: "@grpc/grpc-js"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…rpc-js-1.8.22

build(deps-dev): bump @grpc/grpc-js from 1.8.21 to 1.8.22
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…-3.0.3

build(deps): bump braces from 3.0.2 to 3.0.3
Copy link

github-actions bot commented Jun 13, 2024

Visit the preview URL for this PR (updated for commit 953a75c):

https://ccv-honeycomb--pr493-ref-intro-p-tag-dlun54zj.web.app

(expires Tue, 25 Jun 2024 20:31:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@YUUU23 YUUU23 requested a review from RobertGemmaJr June 13, 2024 14:08
@RobertGemmaJr RobertGemmaJr linked an issue Jun 13, 2024 that may be closed by this pull request
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry! The ticket should have said to add the p tag on the prompt, not the stimuli. Can you update this to fix that issue?

@YUUU23 YUUU23 requested a review from RobertGemmaJr June 13, 2024 21:42
@YUUU23
Copy link
Contributor Author

YUUU23 commented Jun 13, 2024

So sorry! The ticket should have said to add the p tag on the prompt, not the stimuli. Can you update this to fix that issue?

should be changed now! thank you so much for the review : )

Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks so much 🚀

@YUUU23 YUUU23 merged commit b47d5cb into feat-v3.4.1 Jun 18, 2024
8 checks passed
@YUUU23 YUUU23 deleted the ref-intro-p-tag branch June 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add p tag to stimulus in the introduction trial
2 participants