ref: Move event-marker code into Electron
#455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 5b6f291): https://ccv-honeycomb--pr455-ref-event-marker-a32jeuhm.web.app (expires Fri, 12 Apr 2024 20:59:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
RobertGemmaJr
commented
Apr 5, 2024
RobertGemmaJr
commented
Apr 5, 2024
broarr
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
you just needed to update python to get rid of visual studio?
There was a problem hiding this comment.
I needed to update SerialPort, which is why I had to bring all of the event-marker code into the repo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event-markercode into repository directlynode-gypnow rebuilds the correct binaries on Windows even without Visual Studio