Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rename preamble as startBlock #387

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Conversation

RobertGemmaJr
Copy link
Member

  • Renames preamble as startBlock to match the naming convention of other nested timelines
  • Moves camera setup trials into startBlock
  • Changes the order of the trials in startblock:
    1. The name of the experiment is displayed
    2. The experiment enters fullscreen
    3. A welcome message is displayed
    4. Trials used to set up a photodiode and trigger box are displayed (if applicable)
    5. Trials used to set up the user's camera are displayed (if applicable).

closes #366

@RobertGemmaJr RobertGemmaJr self-assigned this Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Visit the preview URL for this PR (updated for commit 2c5f5f7):

https://ccv-honeycomb--pr387-rename-preamble-0zqb6xfq.web.app

(expires Tue, 06 Feb 2024 16:16:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr RobertGemmaJr linked an issue Jan 30, 2024 that may be closed by this pull request
6 tasks
@RobertGemmaJr RobertGemmaJr added the 3.3 Versioning: Issue in regards to version 3.3 release label Feb 1, 2024
Base automatically changed from ref-init to feat-v3.3 February 2, 2024 20:27
@RobertGemmaJr RobertGemmaJr merged commit 94856c2 into feat-v3.3 Feb 2, 2024
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the rename-preamble branch February 2, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3 Versioning: Issue in regards to version 3.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename preamble as startBlock
1 participant