Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorder buttons to be consistent across cards #194

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

hetd54
Copy link
Contributor

@hetd54 hetd54 commented Jul 6, 2023

now alphabetical across all cards

now alphabetical across all cards
@hetd54 hetd54 requested review from eldu and anna-murphy July 6, 2023 17:27
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Visit the preview URL for this PR (updated for commit 391bd24):

https://ccv-brown-edu--pr194-chore-change-button-yld54l6h.web.app

(expires Wed, 26 Jul 2023 17:04:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

Copy link
Contributor

@anna-murphy anna-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was a very good change. I just looked through the rest of the collaborations to double check you didn't miss any, and I didn't find anything!

I'm going to merge main into this branch though so that it's up to date. If the tests pass then I think you're good to merge!

@eldu eldu merged commit 3829834 into main Jul 20, 2023
12 checks passed
@eldu eldu deleted the chore-change-button-titles branch July 20, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants