Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Brainerd lab collaboration #190

Merged
merged 18 commits into from
Jul 19, 2023
Merged

feat: Add Brainerd lab collaboration #190

merged 18 commits into from
Jul 19, 2023

Conversation

RobertGemmaJr
Copy link
Member

I pulled the description right off of Beth's lab's description. I think that's okay?

schemas/collaborations.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Visit the preview URL for this PR (updated for commit ae3f5a2):

https://ccv-brown-edu--pr190-feat-brainerd-lab-6kv5qxdr.web.app

(expires Tue, 25 Jul 2023 16:57:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the department. Otherwise, looks good!

schemas/collaborations.yml Outdated Show resolved Hide resolved
@tdivoll
Copy link
Member

tdivoll commented Jul 7, 2023 via email

@RobertGemmaJr
Copy link
Member Author

RobertGemmaJr commented Jul 7, 2023

It probably should be EEOB

@tdivoll I did confirm with her the department name is "Ecology, Evolution, and Organismal Biology." So the short name should be eeob?

The other collaborations using the "ecology" department are acadia and riddc. Should I update those as well?

CC @hollandjg @mirestrepo

@hollandjg
Copy link
Member

So the short name should be eeob?

I think if we write "ecology-evolution-and-organismal-biology" everywhere (as you have for brainerd) and we use that everywhere, that's the clearest. (I much prefer the long name than the acronym eeob.)

@hollandjg
Copy link
Member

I've made #199 to update the other cases as a PR to this one – @RobertGemmaJr feel free to merge it into here if that works for you!

…nd-organismal-biology

fix: use ecology-evolution-and-organismal-biology in place of ecology for the department
@RobertGemmaJr
Copy link
Member Author

I've made #199 to update the other cases as a PR to this one

Thank you for that! I just merged it in so this PR should be all set?

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@RobertGemmaJr RobertGemmaJr merged commit a238abd into main Jul 19, 2023
12 checks passed
@RobertGemmaJr RobertGemmaJr deleted the feat-brainerd-lab branch July 19, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants