Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI checks for 1.6 #378

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Add CI checks for 1.6 #378

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25fe6e1
Add CI checks for 1.6
Sep 11, 2023
b647fbe
Add databricks tests
Sep 11, 2023
da3c79f
Specify linter version
Sep 11, 2023
e603ab4
Remove databricks
Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_lint_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }} # Check out the code of the PR

- name: Install Python packages
run: python -m pip install dbt-snowflake~=1.6.0 sqlfluff-templater-dbt
run: python -m pip install dbt-snowflake~=1.6.0 sqlfluff-templater-dbt~=2.0.2

- name: Test database connection
run: dbt debug
Expand Down
46 changes: 23 additions & 23 deletions .github/workflows/ci_test_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,26 +138,26 @@ jobs:
run: tox -e integration_${{ matrix.warehouse }}_${{ matrix.version }}

# Databricks doesn't like the matrix strategy, so moving back to the old integration testing without versioning
# integration-databricks:
# runs-on: ubuntu-latest
# environment:
# name: Approve Integration Tests

# steps:
# - name: Checkout
# uses: actions/checkout@v3
# with:
# ref: ${{ github.event.pull_request.head.sha }} # Check out the code of the PR

# - uses: actions/setup-python@v4
# with:
# python-version: '3.8.x'
# architecture: 'x64'

# - name: Install tox
# run: python3 -m pip install tox

# - name: Run Databricks Tests
# env:
# DBT_VERSION: ''
# run: tox -e integration_databricks
integration-databricks:
runs-on: ubuntu-latest
environment:
name: Approve Integration Tests

steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }} # Check out the code of the PR

- uses: actions/setup-python@v4
with:
python-version: '3.8.x'
architecture: 'x64'

- name: Install tox
run: python3 -m pip install tox

- name: Run Databricks Tests
env:
DBT_VERSION: ''
run: tox -e integration_databricks
26 changes: 13 additions & 13 deletions .github/workflows/main_test_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,20 @@ jobs:
run: tox -e integration_${{ matrix.warehouse }}_${{ matrix.version }}

# Databricks doesn't like the matrix strategy, so moving back to the old integration testing without versioning
# integration-databricks:
# runs-on: ubuntu-latest
integration-databricks:
runs-on: ubuntu-latest

# steps:
# - name: Checkout
# uses: actions/checkout@v3
steps:
- name: Checkout
uses: actions/checkout@v3

# - uses: actions/setup-python@v4
# with:
# python-version: '3.8.x'
# architecture: 'x64'
- uses: actions/setup-python@v4
with:
python-version: '3.8.x'
architecture: 'x64'

# - name: Install tox
# run: python3 -m pip install tox
- name: Install tox
run: python3 -m pip install tox

# - name: Run Databricks Tests
# run: tox -e integration_databricks
- name: Run Databricks Tests
run: tox -e integration_databricks
28 changes: 26 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,18 @@ commands =
dbt deps
dbt build --target snowflake

[testenv:integration_snowflake_1_6_0]
changedir = integration_test_project
deps = dbt-snowflake~=1.6.0
commands =
dbt clean
dbt deps
dbt build --target snowflake

# Databricks integration tests
[testenv:integration_databricks]
changedir = integration_test_project
deps = dbt-databricks~=1.4.0
deps = dbt-databricks~=1.6.0
commands =
dbt clean
dbt deps
Expand Down Expand Up @@ -184,10 +192,18 @@ commands =
dbt deps
dbt build --target databricks

[testenv:integration_databricks_1_6_0]
changedir = integration_test_project
deps = dbt-databricks~=1.6.0
commands =
dbt clean
dbt deps
dbt build --target databricks

# Bigquery integration tests
[testenv:integration_bigquery]
changedir = integration_test_project
deps = dbt-bigquery~=1.4.0
deps = dbt-bigquery~=1.6.0
commands =
dbt clean
dbt deps
Expand Down Expand Up @@ -217,6 +233,14 @@ commands =
dbt deps
dbt build --target bigquery --vars '"my_var": "my value"'

[testenv:integration_bigquery_1_6_0]
changedir = integration_test_project
deps = dbt-bigquery~=1.6.0
commands =
dbt clean
dbt deps
dbt build --target bigquery --vars '"my_var": "my value"'

# Spark integration test (disabled)
[testenv:integration_spark]
changedir = integration_test_project
Expand Down