Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth tests #14

Merged
merged 29 commits into from
Jun 22, 2017
Merged

Auth tests #14

merged 29 commits into from
Jun 22, 2017

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Jun 5, 2017

Improve test coverage around BlogAdminController

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #14 into master will increase coverage by 25.14%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
+ Coverage   45.33%   70.47%   +25.14%     
===========================================
  Files          15       14        -1     
  Lines        1458     1460        +2     
===========================================
+ Hits          661     1029      +368     
+ Misses        797      431      -366
Impacted Files Coverage Δ
Sources/SteamPress/Models/BlogTag.swift 91.66% <ø> (+7.05%) ⬆️
Sources/SteamPress/Models/BlogPost.swift 90.74% <ø> (+3.39%) ⬆️
Sources/SteamPress/Models/BlogUser.swift 100% <ø> (ø) ⬆️
...ources/SteamPress/Controllers/BlogController.swift 83.33% <100%> (ø) ⬆️
...rces/SteamPress/Validators/UsernameValidator.swift 100% <100%> (+100%) ⬆️
...s/Middleware/BlogLoginRedirectAuthMiddleware.swift 100% <100%> (+33.33%) ⬆️
...s/SteamPress/Controllers/BlogAdminController.swift 84.61% <100%> (+72.81%) ⬆️
Sources/SteamPress/Provider.swift 5.05% <60%> (+5.05%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fadd8...7842e41. Read the comment docs.

@0xTim 0xTim merged commit 77e96c7 into master Jun 22, 2017
@0xTim 0xTim deleted the authTests branch June 22, 2017 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant