Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support React Native 0.61; drop React Native 0.59 #244

Merged
merged 10 commits into from
Feb 13, 2020

Conversation

brody4hire
Copy link
Owner

@brody4hire brody4hire commented Feb 13, 2020

Major (breaking) updates for new 0.x release:

  • generate example with React Native 0.61 by default
  • remove react-native link step (not needed since React Native 0.60)
  • prep: test with generate example for Android only
    (needed to ensure pod install is not run on example in case the module is for Android only)
  • do pod install in generated example for iOS
  • remove pod install step from manual post-create instructions
  • update generated Android view for React Native 0.60(+)
  • update template devDependencies for React Native 0.61
  • minimum React Native 0.60 in template peerDependencies
  • documentation updates
  • update documentation for out-of-tree platforms
    (not supported by the generated example)

Tested as follows:

  • library module with generated example working on RN 0.61 on Android & iOS
  • view module with generated example working on RN 0.61 on Android & iOS
  • library module with generated example working on RN 0.60 on Android & iOS
  • view module with generated example working on RN 0.60 on Android & iOS

resolves #29
resolves #93
resolves #99
resolves #132
closes #130
closes #192

@brody4hire brody4hire self-assigned this Feb 13, 2020
@brody4hire brody4hire merged commit 1f105df into master Feb 13, 2020
@brody4hire brody4hire deleted the support-react-native-0.61-drop-react-native-0.59 branch February 13, 2020 03:48
@brody4hire
Copy link
Owner Author

Merged in a squash commit, with the commit message cleaned up in line with the changes listed in the description.

Stryker mutation testing shows a couple of surviving mutants that were introduced, which are very minor:

221. [Survived] StringLiteral
/home/brodybits/create-react-native-module/lib/lib.js:259:30
-                   console.error('pod --version failure, aborting with broken example app');
+                   console.error("");

Ran all tests for this mutant.
227. [Survived] StringLiteral
/home/brodybits/create-react-native-module/lib/lib.js:269:30
-                   console.error('pod install failure, aborting with broken example app');
+                   console.error("");

Ran all tests for this mutant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant