Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.x Shift #7

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Laravel 6.x Shift #7

merged 8 commits into from
Oct 26, 2023

Conversation

brodeznodev
Copy link
Owner

This pull request includes the changes for upgrading to Laravel 6.x. Feel free to commit any additional changes to the shift-103323 branch.

Before merging, you need to:

  • Checkout the shift-103323 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, add --no-scripts)
  • Clear any config, route, or view cache
  • Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

Shift automatically applies the Laravel coding style - which uses the PSR-12 coding style as a base with some minor additions.

You may customize the code style applied by configuring [Pint](https://laravel.com/docs/pint), [PHP CS Fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer), or [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) for your project root.

For more information on customizing the code style applied by Shift, [watch this short video](https://laravelshift.com/videos/shift-code-style).
Since PHP 5.4 the short array syntax `[]` may be used instead of `array()`.
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.
@brodeznodev
Copy link
Owner Author

ℹ️ Shift noticed you have additional namespaces in your application. You may use the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

@brodeznodev
Copy link
Owner Author

❌ Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 6 versions and merge any changes:

  • app/Http/Kernel.php
  • resources/lang/en/validation.php

@brodeznodev
Copy link
Owner Author

⚠️ Laravel 6.x consolidated references to /home as a constant within the RouteServiceProvider. This makes it easier to maintain and change in a single place.

Shift automated this change, but could not upgrade the following files since they differed from the default Laravel version. You should compare these files against the default Laravel 6 versions and merge this change:

  • app/Http/Controllers/Auth/LoginController.php
  • app/Http/Controllers/Auth/RegisterController.php
  • app/Http/Middleware/RedirectIfAuthenticated.php

@brodeznodev
Copy link
Owner Author

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 041def17 and make the config file changes manually.

@brodeznodev
Copy link
Owner Author

ℹ️ Laravel 6 changed the default Redis client from predis to phpredis. You may keep using predis by setting REDIS_CLIENT=predis for your environment.

@brodeznodev
Copy link
Owner Author

ℹ️ Shift updated your dependencies for Laravel 6. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 6. Watch dealing with dependencies for tips on handling any Composer issues.

The following dependencies were updated by a major version and may have their own changes. You may check their changelog for any additional upgrade steps.

@brodeznodev
Copy link
Owner Author

ℹ️ The Eloquent model's toArray() method will now cast any attributes that implement Illuminate\Contracts\Support\Arrayable to an array. While unlikely to impact your application, this change could effect code which relies upon the previous data type or output.

@brodeznodev
Copy link
Owner Author

ℹ️ Laravel 6 now requires Carbon 2. While Shift reviewed your application for common breaking changes, you may want to review the Carbon 2 migration notes for additional changes.

@brodeznodev
Copy link
Owner Author

⚠️ Previous versions of Laravel would bind parameters passed to the URL helper methods as placeholder values even if the names mismatched. In Laravel 6, named parameters not matching placeholders are attached to the query string instead.

Shift detected the following route() and action() calls passing named parameters you should review to ensure they match the route placeholder name.

  • app/Http/Controllers/BusinessController.php
  • app/Http/Controllers/CashRegisterController.php
  • app/Http/Controllers/ContactController.php
  • app/Http/Controllers/Optics/ProductController.php
  • app/Http/Controllers/ProductController.php
  • app/Http/Controllers/PurchaseController.php
  • app/Http/Controllers/Restaurant/BookingController.php
  • resources/views/balances_customer/partials/toggle_dropdown.blade.php
  • resources/views/contact/create.blade.php
  • resources/views/contact/index.blade.php
  • resources/views/layouts/partials/sidebar.blade.php
  • resources/views/optics/inflow_outflow/index.blade.php
  • resources/views/optics/product/create.blade.php
  • resources/views/optics/product/edit.blade.php
  • resources/views/optics/product/partials/single_product_details.blade.php
  • resources/views/optics/product/partials/toggle_dropdown.blade.php
  • resources/views/optics/product/partials/variable_product_details.blade.php
  • resources/views/physical_inventory/edit.blade.php
  • resources/views/product/create.blade.php
  • resources/views/product/edit.blade.php
  • resources/views/product/partials/single_product_details.blade.php
  • resources/views/product/partials/variable_product_details.blade.php
  • resources/views/restaurant/booking/show.blade.php
  • resources/views/sale_pos/partials/pos_details.blade.php
  • resources/views/sale_pos/partials/suspended_sales_modal.blade.php
  • resources/views/sale_pos/partials/toggle_dropdown.blade.php
  • resources/views/sell/edit.blade.php
  • resources/views/transaction_payment/show_payments.blade.php

@brodeznodev
Copy link
Owner Author

ℹ️ Laravel 6 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

@brodeznodev
Copy link
Owner Author

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6. If you were using these drivers, you may adopt a community maintained package which provides the driver.

@brodeznodev
Copy link
Owner Author

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

@brodeznodev
Copy link
Owner Author

⚠️ Laravel 6.x has reached end of life. It no longer receives bug fixes or security updates. Shift recommends continuing to upgrade to the latest version (Laravel 10.x).

For tips on running multiple Shifts effectively, watch upgrading old Laravel applications.

@brodeznodev brodeznodev merged commit ddca058 into development Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants