guard against shell pipefails in align_and_count in instances where empty inputs would result in div-by-zero conditions #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty inputs would result in div-by-zero conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guard against shell pipefails in align_and_count in instances where empty inputs would result in div-by-zero conditions
This is also somewhat dependent on broadinstitute/viral-core#102, which helps ensure
samtools idxstatsemits useful outputs in the case of empty read groups in the input (i.e. zero counts are reported for the sequences in the reference fasta used by align_and_count in the event the bam is empty, rather than a single zero for the catchall "*" read category—though with the changes in this PR the latter should now be tolerated)