-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaffolding and reference selection based on ANI #528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpark01
changed the title
WiP: scaffolding multitaxa improvements [not ready]
scaffolding and reference selection based on ANI
Mar 19, 2024
…old reference selection to skani-based
…ilenames when non-unique taxids
After a few runs on production data, the general methodological changes here look good. Some parameter tuning probably remains to be optimized in order to increase the clustering/matching between various rhino C species, but that can be experimented with separately and introduced in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ANI-based mechanisms for reference selection using
skani
. This:select_references
to tasks_assembly.wdl that selects a subset of reference genomes based on ANI similarity to a set of given contigs/MAGs. This also clusters similar reference genomes to each other based on ANI and chooses only the top reference per cluster.scaffold
's behavior in task_assembly.wdl to chose a reference genome based on ANI when provided multiple reference genomes.scaffold_and_refine_multitaxa
to:This updated version of
scaffold_and_refine_multitaxa
should be far more efficient at metagenomic reference selection, produce less noisy outputs (less secondary taxon hits), still allow for diverse coinfections of unrelated taxa, and should perform well with a very large reference genome database as input.This PR also introduces an unrelated change to modify the workflow
terra_tsv_to_table
to accept and concatenate multiple input tsv files.