Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update viral-core 2.3.0 -> 2.3.1 #527

Merged
merged 21 commits into from
Mar 19, 2024
Merged

update viral-core 2.3.0 -> 2.3.1 #527

merged 21 commits into from
Mar 19, 2024

Conversation

tomkinsc
Copy link
Member

update viral-core 2.3.0 -> 2.3.1

update viral-core 2.3.0 -> 2.3.1
@dpark01
Copy link
Member

dpark01 commented Mar 12, 2024

in addition to fixing whatever the build failures are above -- maybe rope in any other viral-XXX docker version updates into this PR as well if you think those will merge quickly upstream?

pin nextstrain/base image to build-20240209T204939Z until a tagged release of the image includes a version of augur with the bugfix included in nextstrain/augur#1439
update nextstrain/base image to build-20240318T173028Z, which should include a version of augur incorporating the bugfix from nextstrain/augur#1439
wildcard stderr and stdout output, since cromwell output files can be called stderr.background and stdout.background rather than simply stderr and stdout
…ocker cid file indicates completion

wait to remove docker images until docker cid file indicates completion
see:
broadinstitute/cromwell#3370 (comment)
Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when you're ready!

@dpark01 dpark01 added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit 9b2059a Mar 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants