Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDL code/style cleanups #523

Merged
merged 3 commits into from
Mar 1, 2024
Merged

WDL code/style cleanups #523

merged 3 commits into from
Mar 1, 2024

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Mar 1, 2024

This PR was originally opened to close #519 and implement runtime hinting for "Ice Lake" to speed up file localization on GCP specifically by up to 10x. It was later observed that this speedup was already happening on some critical tasks without this hinting (most likely because we were specifying LOCAL disks and/or relatively large VM shapes), so this PR no longer adds those runtime hints.

This PR is now exclusively about some cleanups to tasks to update draft-2 syntax to 1.0 for command blocks.

@dpark01 dpark01 marked this pull request as ready for review March 1, 2024 15:53
@dpark01
Copy link
Member Author

dpark01 commented Mar 1, 2024

Some observations of recent runs in Terra using master branch code (ie, not the changes in the PR) suggest that the 10x localization speedup is already happening for the kraken2 and illumina_demux tasks without asking for Ice Lake specifically. I wonder if the GCE custom-shape VMs are defaulting to Ice Lake if the CPU/RAM request is high enough to begin with.

@dpark01 dpark01 changed the title optimize large File localization WDL code/style cleanups Mar 1, 2024
@dpark01 dpark01 merged commit 3b25433 into master Mar 1, 2024
12 checks passed
@dpark01 dpark01 deleted the dp-localization branch March 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed up data localization for certain tasks
1 participant